burble/nomad-driver-containerd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add validations.

Browse Source 
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
This commit is contained in:
Shishir Mahajan 2020-06-29 14:36:03 -07:00
parent 22200eb06c
commit fb3781aba2
No known key found for this signature in database
GPG Key ID: D41782E7688DEC4A
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
containerd/containerd.go
View File

@ -74,6 +74,10 @@ func (d *Driver) createContainer(image containerd.Image, containerName, containe
// https://github.com/containerd/containerd/blob/master/mount/mount_linux.go#L187-L211 // https://github.com/containerd/containerd/blob/master/mount/mount_linux.go#L187-L211
mounts := make([]specs.Mount, 0) mounts := make([]specs.Mount, 0)
for _, mount := range config.Mounts { for _, mount := range config.Mounts {
if (mount.Type == "bind" || mount.Type == "volume") && len(mount.Options) <= 0 {
return nil, fmt.Errorf("Options cannot be empty for mount type: %s. You need to atleast pass rbind and ro.", mount.Type)
}
m := specs.Mount{} m := specs.Mount{}
m.Type = mount.Type m.Type = mount.Type
m.Destination = mount.Target m.Destination = mount.Target

2
containerd/driver.go
View File

@ -82,7 +82,7 @@ var (
hclspec.NewAttr("type", "string", false), hclspec.NewAttr("type", "string", false),
hclspec.NewLiteral("\"volume\""), hclspec.NewLiteral("\"volume\""),
), ),
"target": hclspec.NewAttr("target", "string", false), "target": hclspec.NewAttr("target", "string", true),
"source": hclspec.NewAttr("source", "string", false), "source": hclspec.NewAttr("source", "string", false),
"options": hclspec.NewAttr("options", "list(string)", false), "options": hclspec.NewAttr("options", "list(string)", false),
})), })),