From 24d7f2d73b58f829071a782c208708405e32455b Mon Sep 17 00:00:00 2001 From: Shishir Mahajan Date: Tue, 23 Feb 2021 19:00:10 -0800 Subject: [PATCH] Add comments (notes). --- containerd/containerd.go | 4 ++++ etchosts/etchosts.go | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/containerd/containerd.go b/containerd/containerd.go index a6fed4b..c002c2e 100644 --- a/containerd/containerd.go +++ b/containerd/containerd.go @@ -186,6 +186,10 @@ func (d *Driver) createContainer(containerConfig *ContainerConfig, config *TaskC mounts = append(mounts, allocMount) } + // User will specify extra_hosts to be added to container's /etc/hosts. + // If host_network=true, extra_hosts will be added to host's /etc/hosts. + // If host_network=false, extra hosts will be added to the default /etc/hosts provided to the container. + // If the user doesn't set anything (host_network, extra_hosts), a default /etc/hosts will be provided to the container. var extraHostsMount specs.Mount hostsFile := containerConfig.TaskDirSrc + "/etc_hosts" if len(config.ExtraHosts) > 0 { diff --git a/etchosts/etchosts.go b/etchosts/etchosts.go index f98de7d..eeb1ca1 100644 --- a/etchosts/etchosts.go +++ b/etchosts/etchosts.go @@ -47,7 +47,6 @@ func BuildEtcHosts(hostsFile string) error { return err } } - return ioutil.WriteFile(hostsFile, content.Bytes(), 0644) }